Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Missing Block Data For Node Validator #2351

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix Missing Block Data For Node Validator #2351

wants to merge 5 commits into from

Conversation

Ayiga
Copy link
Member

@Ayiga Ayiga commented Dec 4, 2024 •
edited
Loading

This PR:

  • Fixes missing Block Size Data by sourcing the block data from a separate Block Stream
  • Modifies the way logic for how these data streams are connected, and how they get reconnected when closed
  • Modifies the processing logic to operate on a pair of Leaf and Block data, as the Block data can no longer be reconstructed from a serialized Leaf
  • Removed an early return that may have potentially caused the WebSocket to no longer process incoming connections

Ayiga added 4 commits December 3, 2024 09:17
@Ayiga
Adjust block data source
af826dc 
There has been a change to the serialization of `Leaf` that removes the ability to
deserialize or serialize block data within the `Leaf`. As a result, block size information
is missing.

To fix this issue, we need the `BlockQueryData` in order to determine details about the
`Payload` that are needed for this service. Additionally, the `Leaf` is still needed. So
we need to be able to retrieve two separate `Stream`s, one for the `Leaf`s, and one for
the `BlockQueryData`, and then to combine those entries.  As a result, a solution is needed
to be able to retrieve these entries, and ensure that we are matching them at the correct
offsets.
@Ayiga
Update the history size for votes
4de54a0
@Ayiga
Remove early return when error encountered
16ac2b3
@Ayiga
Add public url resubmission
6476c13
@Ayiga Ayiga changed the title Ts/fix/node-validator-missing-block-data Node Validator Fixes and Improvements Dec 4, 2024
@Ayiga Ayiga changed the title Node Validator Fixes and Improvements Fix Missing Block Data For Node Validator Dec 17, 2024
@Ayiga Ayiga marked this pull request as ready for review December 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

@tbro tbro Awaiting requested review from tbro tbro is a code owner

@imabdulbasit imabdulbasit Awaiting requested review from imabdulbasit imabdulbasit is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ayiga