contracts: only require BLS key to remove staker #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveitser
force-pushed
the
ma/remove-staker-with-bls-key-only
branch
from
043cc65 to
01e77fe
Compare
Changes solidity code (incl. solidity tests) but no updates to bindings and rust code yet.
sveitser
force-pushed
the
ma/remove-staker-with-bls-key-only
branch
from
01e77fe to
ec726f7
Compare
sveitser
requested review from
philippecamacho,
ImJeremyHe,
jbearer,
tbro and
imabdulbasit
as code owners
Ensure that the implementations of these functions to load initial stake table and stake table update are actually exercised in tests.
alysiahuggins
approved these changes
Jan 16, 2025
| @@ -221,6 +207,36 @@ impl From<PeerConfigKeys<BLSPubKey>> for NodeInfoJf { | |||
| } | |||
| } | |||
|
|
|||
| pub fn bls_jf_to_sol(bls_vk: BLSPubKey) -> permissioned_stake_table::G2Point { | |||
There was a problem hiding this comment.
what does this mean? bls_jf_to_sol
There was a problem hiding this comment.
Converting the jellyfish type of BLSPubKey to the solidity type.
There was a problem hiding this comment.
Since neither of these types are owned by this crate we can't implement the From due to the orphan rule. I think it gets somewhat confusing if we create too many type wrappers so just opted for a function here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing a staker from the permissioned stake table the staker is identified by the BLS pub key. It's therefore not necessary to pass any other information to the contract to remove a staker. This PR removes the redundant information that was previously required to remove stakers.