feat: add Stake Table contract API #748
Conversation
| /// | ||
| /// @dev No validity check on `schnorrVK`, as it's assumed to be sender's responsibility, | ||
| /// the contract only treat it as auxiliary info submitted by `blsVK`. | ||
| function register( |
There was a problem hiding this comment.
There are some slight differences when dealing with stake delegation (see PR #14) . In all cases I think it is better to agree on this version of API first, and then make the changes to support delegation.
There was a problem hiding this comment.
sure! is there a TL;DR for the potential conflicts or major incompatibility you can foresee?
I can also try to address some concerns in this PR if desired.
There was a problem hiding this comment.
TL;DR
- We need to register pool members in addition to pool operators. Pool members do not need a BLS/Schnorr key because by they don't run a validator.
- We need to handle pool operator fees (when registering a pool and also allow the operator to modify the fee)
- Reward collection is performed by pool members for better UX.
But again I think it would be better to have the whole system working with delegation first. Adding delegation later should not be too difficult I think.
alxiong
force-pushed
the
stake-table-api
branch
from
4a5a085 to
c83ebbe
Compare
|
No idea what's wrong with the CI. I'm having a look. |
|
@alxiong Can reproduce CI failure locally when using latest foundry so error is likely something related to anvil. I think we can ignore these tests until that's fixed. |
Closes #673
This is a replicate of #743 which is accidentally closed.