Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix new clippy warnings #164

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix new clippy warnings #164

merged 1 commit into from
Dec 16, 2022

Conversation

tessico
Copy link
Contributor

@tessico tessico commented Dec 16, 2022

Description

fixes unnecessary cast.
This was not caught before since it's a new improvement in 1.66 clippy: https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md#rust-166

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@tessico tessico requested a review from a team December 16, 2022 08:31
@alxiong
Copy link
Contributor

alxiong commented Dec 16, 2022

can we just target this commit to #150 instead?

@tessico
Copy link
Contributor Author

tessico commented Dec 16, 2022

I wanted to keep it separate. I'm not sure how long the review process for #150 would take :)

@tessico
Copy link
Contributor Author

tessico commented Dec 16, 2022

If you strongly object to having it separate I don't mind that much.

@tessico tessico merged commit b47a284 into main Dec 16, 2022
@tessico tessico deleted the fix-clippy branch December 16, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants