Add an inherent JsTaggedBase64::to_string method for JS bindings #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1896257024
💛 - Coveralls |
nyospe
reviewed
Feb 25, 2022
| // | ||
| // Note: this method is included for WASM bindings, since the trait methods from Display don't | ||
| // get compiled to WASM. | ||
| #[allow(clippy::inherent_to_string_shadow_display)] |
There was a problem hiding this comment.
Oh, huh. We have https://github.com/SpectrumXYZ/tagged-base64/blob/0159640927e5e1bfeac431f121362c70f0ca7e94/src/lib.rs#L121 for the TaggedBase64 type, it's odd that we don't have the same for the JS Wrapper.
Is a method, as opposed to a standalone function, preferable here? Overloaded name aside?
It actually looks like the to_string function was added specifically for this purpose, before the JsTaggedBase64 proxy, and @pictographer forgot to change the parameter type.
There was a problem hiding this comment.
Incidentally... there's an outstanding issue around this, not a lot of activity. rustwasm/wasm-bindgen#2073
pictographer
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.