Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Build fix #1549

Merged
merged 1 commit into from
Jan 16, 2025
Merged

CI Build fix #1549

merged 1 commit into from
Jan 16, 2025

Conversation

dotMorten
Copy link
Member

@dotMorten dotMorten commented Jan 16, 2025

Description

  • Updates build settings for .NET 9 (removes old runtime identifier workaround no longer needed)
  • Restores with "PublishReadyToRun" to ensure runtimes are available for publish.
  • Disables new XamlC warnings from code analyzer introduced in .net 9 (to be addressed in the future).
  • Correctly sets Android target SDK to match .net 9's sdk

Type of change

  • Build fix

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@dotMorten dotMorten self-assigned this Jan 16, 2025
@dotMorten dotMorten changed the base branch from main to v.next January 16, 2025 00:20
@dotMorten dotMorten merged commit 7f05944 into v.next Jan 16, 2025
2 of 6 checks passed
@dotMorten dotMorten deleted the dotMorten/cibuildfix branch January 16, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants