-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New sample: Edit Features using Feature Forms #1553
New sample: Edit Features using Feature Forms #1553
Conversation
Added implementation for MAUI, WinUI and WPF Added Readme and metadata files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good start, but I think we should avoid using modals in the sample and rely more on XAML in the page to keep the sample cleaner.
...aui.Samples/Samples/Data/EditFeaturesUsingFeatureForms/EditFeaturesUsingFeatureForms.xaml.cs
Show resolved
Hide resolved
...aui.Samples/Samples/Data/EditFeaturesUsingFeatureForms/EditFeaturesUsingFeatureForms.xaml.cs
Outdated
Show resolved
Hide resolved
Add validation errors for feature form
Not able to figure out why the validation checks are failing. |
I'm seeing quite a few local changes when I run You can find it here. If you're running it locally and seeing no changes let me know and I can push what I'm seeing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, let me know if you need a hand with the PR checks and the screenshots.
src/MAUI/Maui.Samples/Samples/Data/EditFeatureAttachments/readme.metadata.json
Outdated
Show resolved
Hide resolved
...UI/Maui.Samples/Samples/Data/EditFeaturesUsingFeatureForms/editfeaturesusingfeatureforms.jpg
Outdated
Show resolved
Hide resolved
...aui.Samples/Samples/Data/EditFeaturesUsingFeatureForms/EditFeaturesUsingFeatureForms.xaml.cs
Outdated
Show resolved
Hide resolved
...S.WinUI.Viewer/Samples/Data/EditFeaturesUsingFeatureForms/EditFeaturesUsingFeatureForms.xaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. A few readme tweaks will improve readability. In agreement with feedback from @duffh. Also, be sure to feature this sample so users see it immediately on the landing page.
src/MAUI/Maui.Samples/Samples/Data/EditFeaturesUsingFeatureForms/readme.md
Outdated
Show resolved
Hide resolved
src/MAUI/Maui.Samples/Samples/Data/EditFeaturesUsingFeatureForms/readme.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pratham, looks great
Description
Added sample for implementation of
FeatureFormView
from Esri/arcgis-maps-sdk-dotnet-toolkitType of change
Platforms tested on
Checklist