Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sample: Edit Features using Feature Forms #1553

Merged

Conversation

prathameshnarkhede
Copy link
Collaborator

@prathameshnarkhede prathameshnarkhede commented Feb 5, 2025

Description

Added sample for implementation of FeatureFormView from Esri/arcgis-maps-sdk-dotnet-toolkit

Type of change

  • New sample implementation

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

Added implementation for MAUI, WinUI and WPF

Added Readme and metadata files
@prathameshnarkhede prathameshnarkhede self-assigned this Feb 5, 2025
@prathameshnarkhede prathameshnarkhede removed the request for review from dotMorten February 5, 2025 18:20
Copy link
Member

@dotMorten dotMorten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start, but I think we should avoid using modals in the sample and rely more on XAML in the page to keep the sample cleaner.

@prathameshnarkhede
Copy link
Collaborator Author

Not able to figure out why the validation checks are failing.
Can someone help me out here?

@prathameshnarkhede prathameshnarkhede marked this pull request as ready for review February 6, 2025 01:35
@duffh
Copy link
Collaborator

duffh commented Feb 6, 2025

Not able to figure out why the validation checks are failing.
Can someone help me out here?

I'm seeing quite a few local changes when I run sample_sync.py. This is what the validation checks run to make sure all of the readmes have matching information and formatting.

You can find it here.

If you're running it locally and seeing no changes let me know and I can push what I'm seeing.

Copy link
Collaborator

@duffh duffh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, let me know if you need a hand with the PR checks and the screenshots.

Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few readme tweaks will improve readability. In agreement with feedback from @duffh. Also, be sure to feature this sample so users see it immediately on the landing page.

Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pratham, looks great

@prathameshnarkhede prathameshnarkhede merged commit a1271ee into main Feb 11, 2025
6 checks passed
@prathameshnarkhede prathameshnarkhede deleted the pratham/new-sample-edit-features-using-feature-forms branch February 11, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants