[T9n] "messages" prop no longer needs to be exposed for usage in tests

[maxpatiiuk]

Description

Blocked by #10310

Every Calcite component declares messages as an undocumented prop for usage in tests.

calcite-design-system/packages/calcite-components/src/components/chip/chip.tsx

Lines 118 to 124 in f50c170

	/**
	* Made into a prop for testing purposes only
	*
	* @internal
	*/
	// eslint-disable-next-line @stencil-community/strict-mutable -- updated by t9n module
	@Prop({ mutable: true }) messages: ChipMessages;

I believe the only usage in tests was this place:

calcite-design-system/packages/calcite-components/src/tests/commonTests/t9n.ts

Lines 36 to 38 in f50c170

	getCurrentMessages = async (): Promise<MessageBundle> => {
	return page.$eval(tag, (component: CalciteComponentsWithMessages) => component.messages);
	};

In Lumina, exposing messages as a prop is not necessary. Instead, the test can access internal component members in the following way:

 getCurrentMessages = async (): Promise<MessageBundle> => { 
   return page.$eval(tag, (el: CalciteComponentsWithMessages) => el.manager.component.messages); 
 }; 

The manager property is the same both on the html proxy element and on the actual lit component. It has a component property for accessing the lit component (in turn, component has an el property for accessing the html proxy).
This property is not part of public typings or public documentation - it's for internal usage only.

Proposed Advantages

Slight performance improvement and bundle size reduction because messages property would no longer need to be included in the lazy-loading metadata for each component.

Which Component

All

Relevant Info

No response

Calcite package

• @esri/calcite-components
• @esri/calcite-components-angular
• @esri/calcite-components-react
• @esri/calcite-design-tokens
• @esri/eslint-plugin-calcite-components

[maxpatiiuk]

Looks like there are also a few other props that were exposed for testing only:

eg carousel.tsx:

[github-actions]

Installed and assigned for verification.

[DitwanP]

🍡 Verified

[github-actions]

Issue #10310 has been closed, this issue is ready for re-evaluation.

cc @geospatialem,@DitwanP