calcite-value-list: Removing an item after re-ordering removes more than one item in certain cases

[jmanke]

Actual Behavior

Removing an item from the calcite-value-list removes more than one item.

Expected Behavior

Removing an item from the calcite-value-list should only remove the item selected to be removed.

Reproduction Steps and Sample

NOTE: This bug seems specific to Ember

Setup

1. Create a calcite-value-list with drag-enabled prop
2. Create a backing class with two items to be rendered as calcite-value-list-items (see code sample for example)
3. When list is re-orded or an item is removed, ensure backing data reflects the change

Repro Steps

1. Drag the second item into the first position of the list
2. Remove the last item in the list
3. Observe both items are removed from the list. However, the backing data is still correct.

Sample:

1. Ember Twiddle

Relevant Info

• Removing the item externally (preventing the item from being removed inside the calcite-value-list) still causes the bug to occur.
• I notice the calcite-value-list takes care of modifying the HTML when re-ordering. It would be nice if the calcite-value-list only emitted an event when it wants to be re-ordered.

Reproducible version: @esri/[email protected]

• CDN
• NPM package

[jmanke]

This is a high priority issue for the Dashboards team 🙂

[Elijbet]

I also noticed that when you drag item 2 into the first position in the list and remove item 2, it won't remove that visually either. The data is still correct (item 1 is the only one in the list) for now, but if you move item 1 again, it just keeps adding it to the list. Deleting one of them removes all of them at once.

ember-value-list-drag-bug.mov

[geospatialem]

Moved to the July milestone for evaluation and upped the time estimate, since it could impact other uses across components.

[jcfranco]

@geospatialem We might need to push this further as there hasn't been any updates on the PR referenced above. 🥲

[geospatialem]

Moved to the October milestone, which will evaluate if:

1. This issue is still valid with the deprecated component and parity of list via Epic: [List and List Item] Add parity support with Value-List and Pick-List with sorting and removing items #6430, and
2. If the Sortable and Ember conflict can be mitigated

[geospatialem]

Spike to determine if the following above is true, and if we should proceed, or close out the above issue.

[jcfranco]

There hasn't been any updates on Sortable regarding this. Unless there are any objections, I'm going to mark this as blocked and we'll revisit once activity resumes on the linked PR above.

[github-actions]

cc @geospatialem, @brittneytewks