Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit storybook build to handle latest cheerio version (CJS/ESM) #4678

Closed
jcfranco opened this issue Jun 2, 2022 · 4 comments
Closed

Revisit storybook build to handle latest cheerio version (CJS/ESM) #4678

jcfranco opened this issue Jun 2, 2022 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-05-28 - May ...

Comments

@jcfranco
Copy link
Member

jcfranco commented Jun 2, 2022

Description

#4677 pinned cheerio to the last working version. We should look into updating our storybook build setup as suggested here to avoid stagnant versions.

Proposed Advantages

  1. Update storybook build to handle any future CJS/ESM packages.
  2. Avoid pinning cheerio's version

Which Component

storybook build

Relevant Info

No response
@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. labels Jun 2, 2022
@jcfranco jcfranco added this to the Freezer milestone Jun 2, 2022
@jcfranco
Copy link
Member Author

Renovate's ignored deps will need to be updated once this is addressed.

@jcfranco jcfranco mentioned this issue May 5, 2024
Merged
@jcfranco
Copy link
Member Author

jcfranco commented May 5, 2024

Handling the latest version of cheerio was addressed by #9105. #9264 should take care of ☝️.

@jcfranco jcfranco self-assigned this May 5, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels May 5, 2024
@jcfranco jcfranco added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. labels May 5, 2024
jcfranco added a commit that referenced this issue May 6, 2024
@jcfranco
chore(renovate): update ignore list (#9264)
27a82dc 
**Related Issue:** #4678

## Summary

Removing `cheerio` and `storybook-addon-html` from Renovate's ignore
list as we are using recent versions of these dependencies.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 7, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco May 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

Installed and assigned for verification.

@jcfranco
Copy link
Member Author

jcfranco commented May 7, 2024 •
edited
Loading

Verified locally via package files and Renovate config.

@jcfranco jcfranco closed this as completed May 7, 2024
@jcfranco jcfranco added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
4 participants
@jcfranco @alisonailea @geospatialem @DitwanP