133 - Add "Powered by Esri" to portal id-referenced VectorBasemapLayer source. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinr
suggested changes
Jul 15, 2022
gavinr
approved these changes
Jul 16, 2022
|
This was released in v3.1.4. |
shawnmgoulet
deleted the
smg/133-powered-by-esri-vectorBasemapLayer-item-id
branch
gavinr-maps
added a commit
to gavinr-maps/esri-leaflet-vector
that referenced
this pull request
Dec 3, 2024
… cases In Esri#135 we added `Util.setEsriAttribution` to add the "Powered by Esri" attribution, but after Esri Leaflet v3.0.10, calling `Util.setEsriAttribution` does not add "Powered by Esri" anymore. Esri Leaflet only adds "Powered by Esri" for dynamic attribution situations. So now for non-dynamic situations, we must add the string ourself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #133, adding "Powered by Esri" to a portal id-referenced
VectorBasemaplayer.