Add popup options to DynamicMapLayer #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgravois
approved these changes
Dec 21, 2017
| var identifyRequest = this.identify().on(this._map).at(e.latlng); | ||
| var identifyRequest; | ||
| if (this.options.popup) { | ||
| identifyRequest = this.options.popup.on(this._map).at(e.latlng); |
There was a problem hiding this comment.
i pushed a small change here to call IdentifyFeatures.on() dynamically even when a custom popup constructor option has been bound to the layer. this is beneficial for two reasons.
- it avoids an error when
on()wasn't chained prior. - even if the method was chained, it avoids passing a stale extent through in the request if the map was panned or zoomed after the layer was instantiated.
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Add popup options to DynamicMapLayer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add through a "popup" option to the DynamicMapLayer constructor, the ability to pass identify options into bindPopup (issue 633)