Check if 'attributionElement' exists. Fixes #1077 #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing _updateMapAttribution, make sure to check if attributionElement actually exists to avoid "TypeError: Cannot set property 'innerHTML' of null". Fixes Esri#1077
|
i'm still not sure why a developer would explicitly nullify the attribution for our basemap specifically to avoid giving credit where credit is due, but there is no harm in trapping for it. thanks @octavm. |
|
Glad I could help :-) |
jgravois
added a commit
that referenced
this pull request
Jul 13, 2018
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Check if 'attributionElement' exists. Fixes Esri#1077
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing _updateMapAttribution, make sure to check if attributionElement actually exists to avoid "TypeError: Cannot set property 'innerHTML' of null". Fixes #1077