Cacheable feature grid #1189
Merged
Cacheable feature grid #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinr
approved these changes
Mar 30, 2020
|
I am just now noticing the unit tests are failing though |
|
This was released in v2.4.0: https://github.com/Esri/esri-leaflet/releases/tag/v2.4.0 |
This was referenced Oct 27, 2021
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Cacheable feature grid
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Cacheable feature grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gavinr @jwasilgeo this PR removes the dependency on
leaflet-virtual-gridand replaces it with a newFeatureGridthat makes a repeatable grid so we can have queries be cached similar to the JS API despite maps having different origins. The code is based on a simplified version of LeafletsGridLayer.You can test this by:
querycalls until you see 304 responses this means the browser has cached the queries@gavinr @jwasilgeo can you validate that this works and that all samples still work. Ideally this should go out without any breaking changes.