-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split calendar notifications into channels #1571
Split calendar notifications into channels #1571
Conversation
Thanks for the PR I think the users will love it ;). What does the @RequiresApi(Build.VERSION_CODES.O) refer to? So far we support Api 21. |
That code is only called by the |
It's not possible to change it in the app, but I'll try to add a link to the channel setting |
Any other things you need to get this merged? :) |
app/src/main/java/com/android/calendar/settings/CalendarPreferences.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/android/calendar/settings/CalendarPreferences.kt
Outdated
Show resolved
Hide resolved
No, for me it fits like this. Hopefully the users like it too ;) |
(Note: F-Droid rollout is blocked by #1607.) |
Really, Thanks for implementing this feature, I'm sure this will also be helpful for me in the future. (I do not know yet a better place to post this, so I post it here.) |
@Zocker1999NET Sorry I really did not think of this usecase. I don't think there is much we should do about it now, two months later, but I hope the impact was not too great for you! |
Closes #1493, closes #67, closes #783, closes #1138