Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle dark mode 🌒 #303

Closed
EthanThatOneKid opened this issue Feb 21, 2022 · 0 comments · Fixed by #352
Closed

Toggle dark mode 🌒 #303

EthanThatOneKid opened this issue Feb 21, 2022 · 0 comments · Fixed by #352
Labels
developer experience Enhancement geared towards the devs enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@EthanThatOneKid
Copy link
Owner

EthanThatOneKid commented Feb 21, 2022

What's your idea?

My eyes, they burn!

This is what most of us think when we open up https://acmcsuf.com because, well, it’s so darn bright! The white background provides a clean feel, but we are due for a darker option for our most loyal visitors.

UI Implementation

There are a few UI approaches for toggling light/dark mode:

  1. We can place a toggle switch input component in a place where the user is able to easily reach via keyboard navigation
  2. We listen for a keyboard combination (e.g. ctrl+l)
  3. We can listen for secret keystrokes (e.g. “acmdark”) ¹ — which opens the door for future Easter eggs

Stylesheet Implementation

When the visitor prefers dark mode, some of the CSS variable colors in global.css are to be appropriately adjusted.

@EthanThatOneKid EthanThatOneKid added enhancement New feature or request developer experience Enhancement geared towards the devs labels Feb 21, 2022
@EthanThatOneKid EthanThatOneKid added this to the v3.0 🌞 milestone Feb 21, 2022
@jaasonw jaasonw added the good first issue Good for newcomers label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Enhancement geared towards the devs enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants