Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating dark and light mode 🎉 #352

Merged
merged 12 commits into from
Mar 19, 2022
Merged

Integrating dark and light mode 🎉 #352

merged 12 commits into from
Mar 19, 2022

Conversation

EthanThatOneKid
Copy link
Owner

@EthanThatOneKid EthanThatOneKid commented Mar 17, 2022

This PR was worked on by the acmcsuf.com team on Friday, March 18th 2022 for the acmDev work session meeting from 4:00 PM to 5:00 PM PST. We created a new AcmToggle Svelte component that toggles the value of the current theme.

Agenda

  • Add simple theme detection and style changes (3bec20e)
  • Develop a new component to toggle the theme somewhere on the footer (Friday)
  • Fine-tune changes made to the styles in both dark and light mode

Co-Authored-By: Angel Armendariz [email protected]
Co-Authored-By: Dylan Morris [email protected]
Co-Authored-By: Angel [email protected]
Co-Authored-By: Joel Anil John [email protected]

Intended to resolve #303.

@EthanThatOneKid EthanThatOneKid added enhancement New feature or request help wanted Extra attention is needed labels Mar 17, 2022
@vercel
Copy link

vercel bot commented Mar 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/3GGxqBF7X6ircAr8KYNykWF9iRPd
✅ Preview: https://acm-csuf-site-git-fix-303-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview March 18, 2022 23:33 Inactive
@vercel vercel bot temporarily deployed to Preview March 18, 2022 23:33 Inactive
@vercel vercel bot temporarily deployed to Preview March 18, 2022 23:33 Inactive
Co-Authored-By: Angel Armendariz <[email protected]>
Co-Authored-By: Dylan Morris <[email protected]>
Co-Authored-By: Angel  <[email protected]>
Co-Authored-By: Joel Anil John <[email protected]>
@vercel vercel bot temporarily deployed to Preview March 19, 2022 00:34 Inactive
Co-Authored-By: Angel Armendariz <[email protected]>
Co-Authored-By: Dylan Morris <[email protected]>
Co-Authored-By: Angel  <[email protected]>
Co-Authored-By: Joel Anil John <[email protected]>
@vercel vercel bot temporarily deployed to Preview March 19, 2022 01:07 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2022 05:09 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2022 06:20 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2022 06:30 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2022 17:05 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2022 20:01 Inactive
@EthanThatOneKid EthanThatOneKid marked this pull request as ready for review March 19, 2022 21:52
@vercel vercel bot temporarily deployed to Preview March 19, 2022 23:40 Inactive
@janiljohn janiljohn merged commit 9695936 into main Mar 19, 2022
@jaasonw jaasonw deleted the fix/303 branch September 7, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle dark mode 🌒
4 participants