Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Redirect doesn't work when clicking on team tiles for Quiz Page. #1133

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

tmbkoren
Copy link
Collaborator

@tmbkoren tmbkoren commented Oct 8, 2024

Similar to #1081 , issue was with casing in TeamMatch enum. It wasn't consistent with lowercase id's we get from the quiz data. So I went ahead and changed all TeamMatch enums to lowercase, which fixed the issue.
image

Unrelated to this issue, design team page for this quiz has a broken image link.
image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tmbkoren tmbkoren linked an issue Oct 8, 2024 that may be closed by this pull request
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit 2bf5d4c
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/670dfec484c257000876d29f
😎 Deploy Preview https://deploy-preview-1133--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmbkoren tmbkoren requested a review from 26samaahmed October 8, 2024 08:07
Copy link
Collaborator

@26samaahmed 26samaahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some links are broken and pictures are out of date but I will fix that on another issue. Good Work 😎

@26samaahmed 26samaahmed merged commit 49b640c into main Oct 15, 2024
5 checks passed
@tmbkoren tmbkoren deleted the fix/1082 branch October 15, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect doesn't work when clicking on team tiles for Quiz Page.
2 participants