Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICPC logo to homepage #1142

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Add ICPC logo to homepage #1142

merged 10 commits into from
Dec 2, 2024

Conversation

Peterchauu
Copy link
Collaborator

Fix 1115:

  • Added 'ICPC' team to the homepage
  • Sorted all of the teams alphabetically
  • Added an additional third row of team members to compensate for new teams

feat-1115

Copy link

netlify bot commented Oct 27, 2024

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit aa0264d
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/674d55287abdd30008b9fda2
😎 Deploy Preview https://deploy-preview-1142--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@26samaahmed 26samaahmed self-requested a review October 27, 2024 06:47
@Peterchauu
Copy link
Collaborator Author

  • Shortened ICPC Title

image

Copy link
Collaborator

@26samaahmed 26samaahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. I think we should re-word the description a bit.

src/routes/(site)/teams.svelte Outdated Show resolved Hide resolved
src/routes/(site)/teams.svelte Show resolved Hide resolved
@Peterchauu
Copy link
Collaborator Author

  • Changed the description of the ICPC team

image

Copy link
Collaborator

@26samaahmed 26samaahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Everything looks good for now, we will work on adding the Node buds logo once the Design Team Finalizes it! Nice job @Peterchauu 👏

@26samaahmed 26samaahmed merged commit 3f6202b into main Dec 2, 2024
5 checks passed
@26samaahmed 26samaahmed deleted the feat/1115 branch December 2, 2024 06:45
@26samaahmed 26samaahmed restored the feat/1115 branch December 2, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants