Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified navbar.svelte such that menu will close when link clicked #153

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Modified navbar.svelte such that menu will close when link clicked #153

merged 2 commits into from
Oct 19, 2021

Conversation

anhduy1202
Copy link
Collaborator

Hi, hope this is the correct way to make a PR, let me know if I need to improve anything in my code, thank you.

@vercel
Copy link

vercel bot commented Oct 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/3tUuoV6iKPfGYAmAhRz7AAqkGvKd
✅ Preview: https://acm-csuf-site-git-fork-anhduy1202-add-na-efcf13-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview October 19, 2021 02:29 Inactive
EthanThatOneKid
EthanThatOneKid requested changes Oct 19, 2021
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is exciting to see the menu closing automatically now! I have a few nitpicks, but once those are resolved we can merge this PR.

src/lib/components/sections/navbar.svelte Outdated Show resolved Hide resolved
src/lib/components/sections/navbar.svelte Outdated Show resolved Hide resolved
src/lib/components/sections/navbar.svelte Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview October 19, 2021 04:14 Inactive
@anhduy1202 anhduy1202 merged commit fa8ad64 into EthanThatOneKid:main Oct 19, 2021
@EthanThatOneKid EthanThatOneKid linked an issue Oct 19, 2021 that may be closed by this pull request
Menu does not close after page navigation 🧱 #124
Closed
@EthanThatOneKid EthanThatOneKid mentioned this pull request Oct 19, 2021
Closed
@EthanThatOneKid EthanThatOneKid added the good first issue Good for newcomers label Oct 20, 2021
@anhduy1202 anhduy1202 deleted the add/navbar.svelte/dropdown-menu branch October 23, 2021 04:09
@EthanThatOneKid EthanThatOneKid added the bugfix A PR that fixes a bug label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanThatOneKid EthanThatOneKid EthanThatOneKid approved these changes

Assignees
No one assigned
Labels
bugfix A PR that fixes a bug good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu does not close after page navigation 🧱
2 participants
@anhduy1202 @EthanThatOneKid