Removed unneeded arrow buttons for event carousel #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/5NuYpGqRKYFETKR1Di79PT7dMy9w |
EthanThatOneKid
requested changes
Oct 31, 2021
EthanThatOneKid
requested changes
Nov 1, 2021
EthanThatOneKid
requested changes
Nov 3, 2021
Comment on lines
22
to
28
| const canScrollLeft = carouselRef.scrollLeft > 0; | ||
| const canScrollRight = | ||
| carouselRef.scrollWidth - carouselRef.scrollLeft - carouselRef.clientWidth < | ||
| scrollIncrementDistance; | ||
| leftButtonEnabled = canScrollLeft; | ||
| rightButtonEnabled = canScrollRight; | ||
| }; |
There was a problem hiding this comment.
Let's wrap this code into to helper function we created before.
debounceTheScroll(() => {
const canScrollLeft = carouselRef.scrollLeft > 0;
const canScrollRight =
carouselRef.scrollWidth - carouselRef.scrollLeft - carouselRef.clientWidth < 1;
leftButtonEnabled = canScrollLeft;
rightButtonEnabled = canScrollRight;
}, Time.Second * 0.75);
EthanThatOneKid
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the arrow buttons are unneeded they are hidden and return when the event carousel is scrollable.
Preceding abandoned PR: link-#177. (It included 3 unnecessary files along with the 1 file I wanted to change)