Created initial, read-only newsletters web interface #244
Conversation
adityashah6
commented
Dec 6, 2021
adityashah6
commented
- created acmcsuf.com/newsletters.xml
- created web interface for acmcsuf.com/newsletters using acmcsuf.com/newsletters.json
- created web interface for each blog post
This is a blog feature for the acm.csuf website.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/vQDHS4xDP9e1K2sLRrRAAtRzjGC9 |
|
In order for the |
src/routes/newsletters/_query.ts
Outdated
| @@ -38,3 +42,36 @@ export const newslettersQuery = `{ | |||
| } | |||
| } | |||
| }`; | |||
|
|
|||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
Why is eslint disabled here?
There was a problem hiding this comment.
Good question. There was likely an eslint error that was not going away easily. Any unnecessary eslint comments (including the one you've mentioned) should be removed before this PR is fully approved/merged.
src/routes/newsletters/index.xml.ts
Outdated
| <content:encoded> | ||
| <div style="margin-top: 50px; font-style: italic;"> | ||
| <strong> | ||
| <a href="${website}/newsletters/${post.id}"> |
There was a problem hiding this comment.
This should be a synopsis of the blog article instead of just having a "Keep reading" link. If it's outside the scope of this PR, I think we should create a new follow-up issue to track it.
There was a problem hiding this comment.
Also, is it a good idea to format RSS XML like it's HTML? HTML is much less strict; the generated output might not be conformant.
There was a problem hiding this comment.
HTML is less strict indeed, so instead, we could use a different approach than using a string template. I have not used this library personally, but node-rss seems to be a possible choice for this purpose. The node-rss repository has not been updated in over 5 years, but that might be fine since RSS feeds are not expected to change anytime soon AFAIK.
* Blog page ready * Removed unused comments * Removed unused thing lol
