Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mike/2022 updates #258

Merged
5 commits merged into from Jan 24, 2022
Merged

Mike/2022 updates #258

5 commits merged into from Jan 24, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 24, 2022

  • Rewritten footer
  • Adjusted naming in navbar
  • Global breakpoint of 900px
  • Depreciating connect page
  • Updated board member list
  • Updated board member photos
  • Adjusted wording of front page components
  • Implemented 404 page graphics

mikeploythai added 2 commits January 23, 2022 17:46
2022 Updates
018e107 
============
- Rewritten footer
- Adjusted naming in navbar
- Global breakpoint of 900px
- Depreciating connect page
- Updated board member list
- Updated board member photos
- Adjusted wording of front page components
Implemented 404 page graphics
9a43fc5
@ghost ghost requested a review from EthanThatOneKid January 24, 2022 02:15
@vercel
Copy link

vercel bot commented Jan 24, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @EthanThatOneKid on Vercel.

@EthanThatOneKid first needs to authorize it.

EthanThatOneKid
EthanThatOneKid requested changes Jan 24, 2022
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally just a few nitpicks from me mostly to remove any comments that we don't need anymore. The new footer, finalized 404 page, and other improvements look great!

src/lib/components/sections/navbar.svelte Outdated Show resolved Hide resolved
src/routes/about.svelte Outdated Show resolved Hide resolved
src/lib/components/sections/navbar.svelte Outdated Show resolved Hide resolved
src/routes/__error.svelte Outdated Show resolved Hide resolved
src/routes/__error.svelte Outdated Show resolved Hide resolved
src/routes/__error.svelte Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jan 24, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/8zbSaZSSdRfJZCgQNBwcfT3YCUVg
✅ Preview: https://acm-csuf-site-git-fork-mikeploythai-mike-a7c705-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview January 24, 2022 03:50 Inactive
@EthanThatOneKid EthanThatOneKid self-requested a review January 24, 2022 17:59
EthanThatOneKid
EthanThatOneKid approved these changes Jan 24, 2022
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contributions!

@vercel vercel bot temporarily deployed to Preview January 24, 2022 18:01 Inactive
@ghost ghost merged commit cf32302 into EthanThatOneKid:main Jan 24, 2022
@EthanThatOneKid EthanThatOneKid mentioned this pull request Jan 24, 2022
Closed
@EthanThatOneKid EthanThatOneKid mentioned this pull request Feb 5, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EthanThatOneKid