Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up Vitest and added some tests #337

Merged
merged 31 commits into from
Mar 17, 2022
Merged

Set up Vitest and added some tests #337

merged 31 commits into from
Mar 17, 2022

Conversation

EthanThatOneKid
Copy link
Owner

@EthanThatOneKid EthanThatOneKid commented Mar 13, 2022 •
edited
Loading

In this PR, the Vitest testing library was set up and used to test this repository for the first time. Below is a list of what changes have been made to make this possible.

Changelog

  • Upgraded all Svelte and SvelteKit dependencies to their latest versions and resolved any resulting breaking changes
  • Added new test job to .github/workflows/check_website.yaml
  • Made appropriate updates to CONTRIBUTING.md
  • Added support for npm t (npm run test) and npm run test:watch commands in package.json
  • Added some sample tests in src/lib/ical/common.test.ts
  • Added simple tests for each page route of the website (e.g. src/routes/_index.test.ts)

Notes

@EthanThatOneKid EthanThatOneKid added documentation Improvements or additions to documentation enhancement New feature or request developer experience Enhancement geared towards the devs devops Some operation must be executed labels Mar 13, 2022
@vercel
Copy link

vercel bot commented Mar 13, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/4aGnEYSW8Z2xn8yuSbAhmDKSv6xV
✅ Preview: https://acm-csuf-site-git-ops-vitest-1-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview March 13, 2022 09:16 Inactive
@vercel vercel bot temporarily deployed to Preview March 13, 2022 09:23 Inactive
@EthanThatOneKid
Update tsconfig.json
9501b8a 
Recommended to wait on this <sveltejs/kit#4118 (comment)>
@vercel vercel bot temporarily deployed to Preview March 13, 2022 09:27 Inactive
@vercel vercel bot temporarily deployed to Preview March 13, 2022 09:31 Inactive
@EthanThatOneKid EthanThatOneKid mentioned this pull request Mar 16, 2022
Closed
@vercel vercel bot temporarily deployed to Preview March 16, 2022 23:16 Inactive
@vercel vercel bot temporarily deployed to Preview March 16, 2022 23:34 Inactive
@vercel vercel bot temporarily deployed to Preview March 16, 2022 23:38 Inactive
EthanThatOneKid
EthanThatOneKid commented Mar 17, 2022
View reviewed changes
Copy link
Owner Author

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a moment to nitpick this PR myself since it spans 50+ different files.

src/lib/ical/common.ts Outdated Show resolved Hide resolved
src/lib/ical/common.ts Outdated Show resolved Hide resolved
src/lib/ical/parse.ts Outdated Show resolved Hide resolved
svelte.config.js Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview March 17, 2022 18:15 Inactive
EthanThatOneKid
EthanThatOneKid commented Mar 17, 2022
View reviewed changes
Copy link
Owner Author

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I technically cannot approve my own pull request, but here is a green checkmark from me: ✅
image

@EthanThatOneKid EthanThatOneKid merged commit 45c858b into main Mar 17, 2022
@jaasonw jaasonw deleted the ops/vitest-1 branch September 7, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
developer experience Enhancement geared towards the devs devops Some operation must be executed documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up Vitest testing ⚡
1 participant
@EthanThatOneKid