Minor design tweaks #405
Merged
Minor design tweaks #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Responsive text sizing via clamp() - Transitioning CSS macros to new naming scheme - Introduced --perma-light, --card-bg, --button-bg, and --button-hover variables for dynamic theming
ghost
added this to the 
ghost
requested a review
from 
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/Fe1ojH5kWakwW5q8Kz6pexJC49Cu |
Closed
added 6 commits
March 27, 2022 15:21
- Changed font macros for paragraphs from size-xs to size-sm - Images use clamp() to scale dynamically - AcmButton re-written to use --button-bg and --button-hover for different styles in light/dark themes - Modified wording in some paragraphs
- Removed what-is-acm.svelte, introduced about-us.svelte - Modified about/index.svelte to accomodate for about-us.svelte - Updated board member list - officer-profile-list.svelte defaults grid to 4 diamonds instead of 3 in desktop mode - Modified officers.json to be alphabetical - Modified tiers.json for role placement
- Cards scale up on hover & active state - Shadows get softer as the card becomes bigger - Outline defaults to ACM color in initial state to be less contrasty to the shadow - Join button hover effect consistent with other ACM buttons now
- Also deprecated old connect page
jaasonw
force-pushed
the
mike/design-tweaks
branch
from
99b0589 to
9f578e1
Compare
|
Removing navbar and footer changes from this pr bcus they're in #401 |
jaasonw
approved these changes
Mar 27, 2022
jaasonw
suggested changes
Mar 27, 2022
This was referenced Mar 31, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROPOSAL
CHANGELOG
This is change #6 of my big update to prepare for next semester's codebase.
fixes #398