Birth of parseBool()
#455
Merged
Birth of parseBool()
#455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thank you for publishing your progress on #422! I left a few comments with my suggestions for techniques writing the isStringTruthy utility function 😎
Reminder: Once your PR is no longer a WIP, update its name to accurately reflect the changes you will have made.
Co-authored-by: Ethan Davidson <[email protected]>
Co-authored-by: Ethan Davidson <[email protected]>
Co-authored-by: Ethan Davidson <[email protected]>
- Generated 10 events from the existing `events.ics` testdata file. - Created a test that verifies that the ICAL parser parses the code deterministically as expected.
This reverts commit af8c952.
EthanThatOneKid
changed the title
determineTruthyString()parseBool()
This reverts commit f6f85d1.
jaasonw
suggested changes
May 24, 2022
jaasonw
reviewed
May 24, 2022
… parseBool that isn't falsy should return true. Resolves <https://github.com/EthanThatOneKid/acmcsuf.com/pull/455/files#r879979282>.
jaasonw
approved these changes
Aug 29, 2022
jaasonw
pushed a commit
to jaasonw/acmcsuf.com
that referenced
this pull request
Aug 29, 2022
* added common util folder, implemented isStringTruthy, added isPinned to acmEvent * cast DEBUG to string to check * Update isStringTruthy function signature Co-authored-by: Ethan Davidson <[email protected]> * Update isStringTruthy truthy check Co-authored-by: Ethan Davidson <[email protected]> * Update src/lib/common/utils.ts Co-authored-by: Ethan Davidson <[email protected]> * modified isStringTruthy and added test cases * Refactored truthiness checker function - Renamed to `determineTruthyString` * Updated tests for `determineTruthyString` * Updated import for `determineTruthyString` * Attempt number 1 at _Recent Events_ UI * Added ICAL parser integration testing - Generated 10 events from the existing `events.ics` testdata file. - Created a test that verifies that the ICAL parser parses the code deterministically as expected. * Show sample events if in debug mode and no events currently exist * Progress * Updated sample event data * This commit should fail the tests, but it won't * Resolved <EthanThatOneKid#455 (comment)> and <EthanThatOneKid#455 (comment)> * Revert "Attempt number 1 at _Recent Events_ UI" This reverts commit af8c952. * Renamed `determineTruthyString` to `parseBool` * Revert "This commit should fail the tests, but it won't" This reverts commit f6f85d1. * Included a case for "any non-falsy string" since any string passed to parseBool that isn't falsy should return true. Resolves <https://github.com/EthanThatOneKid/acmcsuf.com/pull/455/files#r879979282>. * Refactored parseBool function Resolved <https://github.com/EthanThatOneKid/acmcsuf.com/pull/455/files#r878605080>. Resolved <https://github.com/EthanThatOneKid/acmcsuf.com/pull/455/files#r878605142>. * This is true progress. Co-authored-by: Ethan Davidson <[email protected]>
jaasonw
pushed a commit
to jaasonw/acmcsuf.com
that referenced
this pull request
Aug 29, 2022
* added common util folder, implemented isStringTruthy, added isPinned to acmEvent * cast DEBUG to string to check * Update isStringTruthy function signature Co-authored-by: Ethan Davidson <[email protected]> * Update isStringTruthy truthy check Co-authored-by: Ethan Davidson <[email protected]> * Update src/lib/common/utils.ts Co-authored-by: Ethan Davidson <[email protected]> * modified isStringTruthy and added test cases * Refactored truthiness checker function - Renamed to `determineTruthyString` * Updated tests for `determineTruthyString` * Updated import for `determineTruthyString` * Attempt number 1 at _Recent Events_ UI * Added ICAL parser integration testing - Generated 10 events from the existing `events.ics` testdata file. - Created a test that verifies that the ICAL parser parses the code deterministically as expected. * Show sample events if in debug mode and no events currently exist * Progress * Updated sample event data * This commit should fail the tests, but it won't * Resolved <EthanThatOneKid#455 (comment)> and <EthanThatOneKid#455 (comment)> * Revert "Attempt number 1 at _Recent Events_ UI" This reverts commit af8c952. * Renamed `determineTruthyString` to `parseBool` * Revert "This commit should fail the tests, but it won't" This reverts commit f6f85d1. * Included a case for "any non-falsy string" since any string passed to parseBool that isn't falsy should return true. Resolves <https://github.com/EthanThatOneKid/acmcsuf.com/pull/455/files#r879979282>. * Refactored parseBool function Resolved <https://github.com/EthanThatOneKid/acmcsuf.com/pull/455/files#r878605080>. Resolved <https://github.com/EthanThatOneKid/acmcsuf.com/pull/455/files#r878605142>. * This is true progress. Co-authored-by: Ethan Davidson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/lib/common/utils.tsfor general purpose utility functionsisStringTruthythereisStringTruthyfunctionacmEventinterface to includeisPinned : booleanattribute