Added code block support to the blog #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a. allow child components to modify the font family
b. contain --acm-canvas for code block background (actual color can be updated later)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaasonw
changed the title
|
cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently looks like this
Would like feedback on
a. What color we should use for the background (they're copy pasted from github along with the syntax highlighting)
b. How to make syntax-highlight.css less repetitive as scss does not seem to work??
I also updated the test cases and test data to reflect these changes