update officers, fix term selection button #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EthanThatOneKid
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
LGTM.
You have successfully manually updated the officer images and required metadata for the Fall 2022 semester as requested by #507.
This PR goes on to make various small changes, which I will help list here. They are all related to the surrounding /about page and the idea of getting ready for the 2022 school year.
- Center aligns value of utility component
acm-select.svelte - Shows the Fall 2022 term as an option on
/about'sacm-select.svelte - Declares
acm-pinkas Design team color, leaving Create declaration for backward-compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #507
Create officers kept in for backwards compat