Revert "Refactored caching logic for individual blog posts" #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9df87d0.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EthanThatOneKid
approved these changes
Sep 1, 2022
NLTN
added a commit
that referenced
this pull request
Sep 1, 2022
* Added Filter by Tag feature * Added TagField component * Updated TagField on:change event & Fixed minor bugs * Updated TagField + Added discernTags() + Modified fetchNewsletters() TagField can work with Javascript disabled. * Optimized discernTags() * Update src/lib/components/utils/acm-tagfield.svelte Great suggestion. Much cleaner code & avoid bugs. Co-authored-by: Ethan Davidson <[email protected]> * Update src/routes/blog/index.xml.ts OMG. Deconstructor syntax is so helpful. Co-authored-by: Ethan Davidson <[email protected]> * Fix bugs and improved code quality. * Created a unit test for discernTags() function * Added Svelte Slot component to TagField component * Code refactoring. Change the word "Tag" with "Label". * Optimized filterPosts() * Changed slot name. * Update src/lib/components/utils/acm-labelfield.svelte Co-authored-by: Ethan Davidson <[email protected]> * Update src/routes/blog/index.svelte Co-authored-by: Ethan Davidson <[email protected]> * Remove unnecessary code * Update src/routes/blog/index.json.ts Co-authored-by: Ethan Davidson <[email protected]> * Fixed lint errors * Hide LabelField if there is no posts * Fixed a mistake made when merging conflicts Somehow, I managed to empty out the contents of `/src/lib/common/utils.ts`. I put them back, merged. * Added support for the "no posts" UI state. * Removed unused import to pass the tests! * Refactored `fetchNewsletters` to handle DEBUG mode logic * Made blog page to work with/without Javascript. * Revert "Revert "Refactored caching logic for individual blog posts (#515)" (#524)" This reverts commit 7db1f3b. * Fixed typo in blog page title [4:48 PM]jasonw: i forgot to put post but [4:48 PM]jasonw: change blog back to readme Co-authored-by: Ethan Davidson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test revert to see if it fixes broken blog