Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback fonts and set font-display to fallback #576

Merged
merged 3 commits into from
Sep 23, 2022

Conversation

mikelee
Copy link
Contributor

@mikelee mikelee commented Sep 21, 2022

I added Verdana because it more closely matches Poppins per https://meowni.ca/font-style-matcher/

I also thought it would be a good idea to set the font-display to fallback. If you would prefer a different behavior, check out https://web.dev/font-best-practices/#choose-an-appropriate-font-display-strategy

Fixes #574

@vercel
Copy link

vercel bot commented Sep 21, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @EthanThatOneKid on Vercel.

@EthanThatOneKid first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 3:19AM (UTC)

Copy link
Contributor

@jaasonw jaasonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it 👍

Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing your thought process. This looks great!

@jaasonw jaasonw merged commit a6a3221 into EthanThatOneKid:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: No fallback fonts
3 participants