First Contribution: I added a circle to the confetti, I think #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @EthanThatOneKid on Vercel. @EthanThatOneKid first needs to authorize it. |
JHMuir
changed the title
EthanThatOneKid
requested changes
Nov 5, 2022
There was a problem hiding this comment.
There is only a minor change keeping you from saying, "first try 😎", but luckily it is a super minor change needed to make your SVG file valid. I left a suggestion in my review, feel free to commit the suggestion directly or add it manually if you have additional changes :).
|
Also for future reference, your pull requests should contain the following |
Renamed 'my-new-thing.ts' to 'circle-thing.ts' Fixed the dimensions of 'circle-thing.svg'
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EthanThatOneKid
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.