-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new page for board applications #754
Conversation
✅ Deploy Preview for acmcsuf ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Resolves <#754 (comment)>.
Resolves <#754 (comment)>.
We honestly don’t need the second header. |
I just noticed this on my iPhone! Thanks for sharing the screenshot. |
Oops; I intend to double check this. |
3rd header same issue |
Attempt to resolve <#754 (comment)>.
Resolves <#754 (comment)>.
This is unusual. I can confirm it does not work as well as any other local additions to |
Looks amazing! Thank you so much for bringing my figma design to reality and also making it even better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:)
Thank you for the kind words! |
ScreenshotsTaken from a2ec585. CollapsedExpanded |
why left justified headings when all other headings on the site are centered? |
Though this does not follow best practices, there are various examples in acmcsuf.com v4.0, such as In short, yes you’re right, but as this is a one-off page I am saving that level of consistency for the upcoming redesign. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the apply button now works on both desktop and mobile (safari). I don't mind the opening and ending content to be aligned to the left. This page can definitely be improved on for future uses but I do need this page ASAP so thank you so much for creating it!
Create new page for board applications (#754)
/s23positions
This PR creates a new page for board applications, as per the request in #750. The page can be found at https://acmcsuf.com/s23positions.
The form for students to apply can be accessed via the following link: https://acmcsuf.com/s23apply
The button on the page links to the form for students to apply.
The content for the page, including information about each application, has been copied and pasted from the following Google Doc: https://docs.google.com/document/d/1jTtr2UUEJsRsz0AOQPTe_f0lDk89BK_tfiw590o_U_s/edit#heading=h.yqghk8npo2et
The page design can be viewed at the following Figma link: https://www.figma.com/file/25dCY91gyAqADj3aB9xgfl/Board-Apps?node-id=0%3A1&t=WA866jRB4hQrFrrN-0
Changelog
/s23positions
src/lib/public/board/data/tiers.json
--acm-foundry-rgb
,--acm-marketing-rgb
, and.brand-italic
tostatic/global.css
Resolves #750