Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove preventDefault from anchor navigation #775

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Remove preventDefault from anchor navigation #775

merged 1 commit into from
Feb 18, 2023

Conversation

EthanThatOneKid
Copy link
Owner

I won't lie, I accidentally put preventDefault on the links in the navbar.

@netlify
Copy link

netlify bot commented Feb 18, 2023 •
edited
Loading

✅ Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit bbc5f9b
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/63f0216fc0a0b40008dbe7b3
😎 Deploy Preview https://deploy-preview-775--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@EthanThatOneKid EthanThatOneKid requested review from karnikaavelumani and charliettaylor and removed request for karnikaavelumani February 18, 2023 00:53
@EthanThatOneKid EthanThatOneKid enabled auto-merge (squash) February 18, 2023 01:10
charliettaylor
charliettaylor approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@charliettaylor charliettaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was stop propagation but this works now, good job Ethan :-)
bob

@EthanThatOneKid EthanThatOneKid merged commit d942274 into main Feb 18, 2023
karnikaavelumani
karnikaavelumani reviewed Feb 18, 2023
View reviewed changes
Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for catching this error and fixing it quickly!

@EthanThatOneKid
Copy link
Owner Author

Thank you so much for catching this error and fixing it quickly!

You caught it! It takes a village 🏘️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karnikaavelumani karnikaavelumani karnikaavelumani left review comments

@charliettaylor charliettaylor charliettaylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EthanThatOneKid @charliettaylor @karnikaavelumani