Skip to content
This repository has been archived by the owner on Dec 24, 2022. It is now read-only.

The button/icon, which opens the left panel, makes an awkward rotational movement while the left panel is being opened #61

Closed
wp9015362 opened this issue Aug 23, 2015 · 2 comments
Assignees
Labels

Comments

@wp9015362
Copy link

@Etuldan :

I noticed that the the button/icon, which opens the left panel, makes an awkward rotational movement while the left panel is being opened.

Could you please fix that?

Regards

@Etuldan
Copy link
Owner

Etuldan commented Aug 23, 2015

Indeed, it's useless on (my) Nexus4, but as this function was implemented, maybe it can be useful in some cases ?

@wp9015362
Copy link
Author

@Etuldan :

I had a look a the Google Material Design guidelines to see if I can find any information regarding this rotational animation.

And I indeed was able to find it.

It is shown over there (see "Radial reaction" animaton):

https://www.google.com/design/spec/animation/responsive-interaction.html#responsive-interaction-user-input

And it is also shown over there (see the two animations at the top of the page):

https://www.google.com/design/spec/animation/delightful-details.html

But, as you can see, it is used to make the "menu" icon transition into the "arrow back" icon.

However, in spaRSS the menu icon does not transition into the arrow back icon. Or at least not visibly, since the left panel hovers over the menu button, essentially making the area where the menu button is invisible.

I also had a look at the latest version of the official Gmail app.

The latest version of the official Gmail app does not rotate the menu button when the left panel is being opened.

So, IMHO spaRSS also should not rotate the menu button when the left panel is being opened.

Regards

@Etuldan Etuldan added the bug label Sep 18, 2015
@Etuldan Etuldan self-assigned this Sep 18, 2015
@Etuldan Etuldan closed this as completed Sep 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants