Allows setting a thumbnail image #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use ImageRow in a project that works with a REST API. When the object the user does edit using an Eureka form already has an image defined for the attribute associated with the ImageRow I only want to download a thumbnail from the server to show an image is already set. However I do not want to set the
valueof the ImageRow to the thumbnail image because thevalueis always considered as representing the full resolution image set by the user.Therefore this PR introduces a new attribute
thumbnailImageto ImageRow which allows setting a thumbnail image and does not conflict with the actual value of the ImageRow.