handle reference cycles in is_deep_equal
to avoid stack overflow
#4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was scratching my head, thinking if it's just a "garbage in, garbage out" situation and it's best to ignore it. but i looked at some other assertion frameworks to see if they handle this sort of thing, and they typically do. since the code changes are minimal, and the extra memory it uses to keep track of visited tables is bounded by the size of the tables being compared, i feel like it's worth it.
the first test i added actually passes in the original
is_deep_equal
implementation, but i thought it is just a good test to have. the last two tests would go into infinite recursion without this fix.