Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Automatic Region Retrying for S3 Native Downloader #1098

Merged
merged 5 commits into from
Jun 27, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Jun 27, 2023

  • Enables auto retrying and client creation when a s3 fetch is different than the current bucket.
  • Enables multiple s3 client to support multi region workloads
  • Enables credential checking when creating s3 client and propagation

@samster25 samster25 changed the title Sammy/s3 region retry [FEAT] Automatic Region Retrying for S3 Native Downloader Jun 27, 2023
@github-actions github-actions bot added the enhancement New feature or request label Jun 27, 2023
@samster25 samster25 enabled auto-merge (squash) June 27, 2023 05:47
@samster25 samster25 force-pushed the sammy/s3-region-retry branch from ee6f982 to b215d8c Compare June 27, 2023 05:48
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1098 (b215d8c) into main (9e4256f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1098   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files          54       54           
  Lines        5463     5463           
=======================================
  Hits         4833     4833           
  Misses        630      630           

@samster25 samster25 disabled auto-merge June 27, 2023 05:59
@samster25 samster25 merged commit 31f8154 into main Jun 27, 2023
@samster25 samster25 deleted the sammy/s3-region-retry branch June 27, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant