Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Native Downloader add Retry Config parameters #1244

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Aug 8, 2023

  • allows user to specify the number of tries and the initial backoff duration
    io_config=IOConfig(
        s3=S3Config(num_tries=10, retry_initial_backoff_ms=1000),
    )

@github-actions github-actions bot added the enhancement New feature or request label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1244 (c5f2630) into main (864be06) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1244      +/-   ##
==========================================
- Coverage   87.24%   87.23%   -0.02%     
==========================================
  Files          62       62              
  Lines        5928     5928              
==========================================
- Hits         5172     5171       -1     
- Misses        756      757       +1     

see 1 file with indirect coverage changes

@samster25 samster25 force-pushed the sammy/native-retry-config branch from ce72b4c to f7c9fb6 Compare August 8, 2023 23:19
@samster25 samster25 requested a review from jaychia August 8, 2023 23:51
@samster25 samster25 changed the title [FEAT] Native Retry Config [FEAT] Native Downloader add Retry Config parameters Aug 8, 2023
@samster25 samster25 merged commit 5e762f5 into main Aug 9, 2023
@samster25 samster25 deleted the sammy/native-retry-config branch August 9, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant