Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] add IOStats to all micropartition ops #1584

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Nov 8, 2023

  • Makes IOStats required for micropatition ops that may be lazy and call tables_or_read, concat_or_read.
  • Add annotations for all ops that call the methods above
  • update iostats to use Cow<'static, str> since many of the strings we use is static.

@github-actions github-actions bot added the chore label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #1584 (8064568) into main (b4467ad) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1584   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files          54       54           
  Lines        5222     5222           
=======================================
  Hits         4424     4424           
  Misses        798      798           

@samster25 samster25 force-pushed the sammy/io-stats-for-every-mp-op branch from c8e4db9 to 304f686 Compare November 13, 2023 22:50
@samster25 samster25 changed the title [CHORE] add io stats to all mp ops [CHORE] add IOStats to all micropartition ops Nov 13, 2023
@samster25 samster25 merged commit a316bde into main Nov 13, 2023
39 checks passed
@samster25 samster25 deleted the sammy/io-stats-for-every-mp-op branch November 13, 2023 23:29
Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be cool if eventually we have some kind of annotation like #[io_stats = "Table concatting lazy materialization"]

@samster25
Copy link
Member Author

Could be cool if eventually we have some kind of annotation like #[io_stats = "Table concatting lazy materialization"]

I'll probably work on some viz tool that will show that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants