Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: ide completions for expr namespaces #2374

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[BUG]: ide completions for expr namespaces #2374

merged 1 commit into from
Jun 14, 2024

Conversation

universalmind303
Copy link
Contributor

@universalmind303 universalmind303 commented Jun 13, 2024 •
edited
Loading

closes #2366

image

@universalmind303 universalmind303 changed the title fix ide completions for expr namespaces [BUG]: ide completions for expr namespaces Jun 13, 2024
@github-actions github-actions bot added the bug Something isn't working label Jun 13, 2024
@universalmind303
Copy link
Contributor Author

CI failure looks like a flake https://github.com/Eventual-Inc/Daft/actions/runs/9502021439/job/26189671812?pr=2374 and unrelated to PR.

@samster25
Copy link
Member

Just retirggered the CI run, IDK why github actions have been so flaky lately. @jaychia Can you take a look?

@samster25 samster25 requested a review from jaychia June 13, 2024 19:30
jaychia
jaychia approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 thanks for catching this! I added a bunch of logic to fix the REPL autocomplete, but I guess it made the IDE autocomplete funky

@samster25 samster25 merged commit 041a73a into Eventual-Inc:main Jun 14, 2024
43 of 44 checks passed
@jaychia
Copy link
Contributor

jaychia commented Jun 21, 2024

BTW It seems that this PR fixes autocomplete for IDEs, but breaks it for the REPL..

Autocomplete in the REPL uses the jedi library, which IIRC has some corner-casing around the name of the @property decorator being named exactly "property"... See #2251 for where I originally tried to fix it.

@universalmind303 universalmind303 deleted the expr-completions branch January 23, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaychia jaychia jaychia approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE completions are not working properly for str namespace
3 participants
@universalmind303 @samster25 @jaychia