Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] with_column with existing column name should not reorder columns #2381

Merged
merged 3 commits into from
Jun 18, 2024
Merged

[BUG] with_column with existing column name should not reorder columns #2381

merged 3 commits into from
Jun 18, 2024

Conversation

colin-ho
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Jun 15, 2024
kevinzwang
kevinzwang approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Maybe we should also add ordering tests for other dataframe operations such as select to protect from potential future regressions

@colin-ho colin-ho force-pushed the colin/fix-with-column branch from 959396a to e965d44 Compare June 18, 2024 05:13
@colin-ho colin-ho merged commit f0b35e3 into main Jun 18, 2024
43 checks passed
@colin-ho colin-ho deleted the colin/fix-with-column branch June 18, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzwang kevinzwang kevinzwang approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-ho @kevinzwang