Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE]: move uri functions to new "daft-functions" crate #2501

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

universalmind303
Copy link
Contributor

so i totally forgot about typetag when I did #2466. So the whole registry thing isn't even needed anymore, which greatly simplifies things.

@universalmind303 universalmind303 changed the title [REFACTOR]: move uri functions to new "daft-functions" crate [CHORE]: move uri functions to new "daft-functions" crate Jul 11, 2024
@github-actions github-actions bot added the chore label Jul 11, 2024
Copy link
Member

@samster25 samster25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is much cleaner overall for inter-crate functions!

src/daft-dsl/Cargo.toml Show resolved Hide resolved
src/daft-plan/Cargo.toml Outdated Show resolved Hide resolved
@universalmind303 universalmind303 enabled auto-merge (squash) July 12, 2024 02:47
@universalmind303 universalmind303 merged commit dbedd52 into Eventual-Inc:main Jul 12, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants