Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add tests for decimal casting #3179

Merged

Conversation

desmondcheongzx
Copy link
Contributor

There are no existing tests for decimal casting. This PR adds some randomized tests.

Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Merging #3179 will not alter performance

Comparing desmondcheongzx:decimal-cast-tests (13c2148) with main (64e35f8)

Summary

✅ 17 untouched benchmarks

Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuzzy_eq looks good to me. LGTM!

@desmondcheongzx desmondcheongzx merged commit 2829a09 into Eventual-Inc:main Nov 6, 2024
38 checks passed
@desmondcheongzx desmondcheongzx deleted the decimal-cast-tests branch November 6, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants