-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(list): add fixed-size list support for value_counts #3521
Conversation
also unsure whether this should be |
CodSpeed Performance ReportMerging #3521 will degrade performances by 57%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3521 +/- ##
==========================================
+ Coverage 77.51% 77.54% +0.03%
==========================================
Files 709 709
Lines 86279 86286 +7
==========================================
+ Hits 66880 66912 +32
+ Misses 19399 19374 -25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, agreed with @universalmind303's comments will let him do the final signoff
662ebd7
to
1a2ba6f
Compare
1a2ba6f
to
f3f2aaa
Compare
Closes #3519