Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): add fixed-size list support for value_counts #3521

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

andrewgazelka
Copy link
Contributor

Closes #3519

@github-actions github-actions bot added the feat label Dec 9, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka marked this pull request as ready for review December 9, 2024 09:24
@andrewgazelka
Copy link
Contributor Author

andrewgazelka commented Dec 9, 2024

also unsure whether this should be feat or fix... given to end user it might seem like a feat? 😅 feel free to change PR title

Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #3521 will degrade performances by 57%

Comparing andrew/fixed-value-counts (f3f2aaa) with main (6390afa)

Summary

❌ 2 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/fixed-value-counts Change
test_iter_rows_first_row[100 Small Files] 127.5 ms 296.5 ms -57%
test_show[100 Small Files] 15.8 ms 23.5 ms -32.78%

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.54%. Comparing base (6390afa) to head (f3f2aaa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-core/src/array/fixed_size_list_array.rs 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3521      +/-   ##
==========================================
+ Coverage   77.51%   77.54%   +0.03%     
==========================================
  Files         709      709              
  Lines       86279    86286       +7     
==========================================
+ Hits        66880    66912      +32     
+ Misses      19399    19374      -25     
Files with missing lines Coverage Δ
src/daft-functions/src/list/value_counts.rs 72.50% <100.00%> (+14.60%) ⬆️
src/daft-core/src/array/fixed_size_list_array.rs 82.56% <87.50%> (+9.10%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agreed with @universalmind303's comments will let him do the final signoff

@andrewgazelka andrewgazelka force-pushed the andrew/fixed-value-counts branch 2 times, most recently from 662ebd7 to 1a2ba6f Compare December 9, 2024 22:14
@andrewgazelka andrewgazelka requested review from universalmind303 and removed request for desmondcheongzx December 9, 2024 22:14
@andrewgazelka andrewgazelka force-pushed the andrew/fixed-value-counts branch from 1a2ba6f to f3f2aaa Compare December 9, 2024 22:17
@andrewgazelka andrewgazelka merged commit 092c354 into main Dec 10, 2024
43 of 44 checks passed
@andrewgazelka andrewgazelka deleted the andrew/fixed-value-counts branch December 10, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expression.list.value_counts does not work for fixed size lists
3 participants