Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Always download logs #3588

Merged
merged 1 commit into from
Dec 18, 2024
Merged

ci: Always download logs #3588

merged 1 commit into from
Dec 18, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Dec 17, 2024

Changes code to always download logs even in the event of a failure

@jaychia jaychia requested a review from raunakab December 17, 2024 07:21
@github-actions github-actions bot added the ci label Dec 17, 2024
Copy link

codspeed-hq bot commented Dec 17, 2024

CodSpeed Performance Report

Merging #3588 will improve performances by 13.77%

Comparing jay/always-pull-logs (becf36b) with main (4bb0413)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main jay/always-pull-logs Change
test_count[1 Small File] 3.6 ms 3.2 ms +13.77%

@jaychia jaychia enabled auto-merge (squash) December 18, 2024 09:19
@jaychia jaychia force-pushed the jay/always-pull-logs branch from 67c8784 to becf36b Compare December 18, 2024 10:00
@jaychia jaychia merged commit 07752b8 into main Dec 18, 2024
41 checks passed
@jaychia jaychia deleted the jay/always-pull-logs branch December 18, 2024 10:21
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (4bb0413) to head (becf36b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3588      +/-   ##
==========================================
- Coverage   77.86%   77.85%   -0.01%     
==========================================
  Files         719      719              
  Lines       88455    88455              
==========================================
- Hits        68872    68871       -1     
- Misses      19583    19584       +1     

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants