-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter feature works #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! A few things to look at.
I also want to consider how a user might supply filters/searches through the API. For example, a user might have a text box outside the table to supply a filter term. Can we add a way to supply the filter term as well as the text input you've added? I do really like the /
as I live in vim and that feels natural to me. :D
There will be room for expanding this in the future for things like numerical comparisons/filters, but I think that can definitely be another PR as long as we leave room for it.
Just a note, we also need to make sure to fix the linting/testing coverage. I unfortunately do want to stay strict with that, as it's caught many of my own mistakes even in this project. |
Sure. |
Hey there, just checking if you were able to add some coverage. If not, I'm willing to help out here. There appear to be some existing bugs regarding the selectable rows that snuck in unrelated to this PR, and another issue that would collide with the keymap added in this PR, so I'd like to unblock this if you find the test coverage requirements painful. |
@Evertras I added as more unit tests as I can. And I merged with upstream main branch(solved some conflicts). If the coverage is still under the required, help is wanted~ |
Thanks! Just a few linting things snuck in... a quick |
@Evertras thanks for point out. Style issues were fixed. |
Thank you for the patience, I'll take care of the coverage gap; I'll just not make a release until I fix that. Appreciate the work! |
@Evertras Maybe |
Request #5 is done.
demo
go run examples/filter/main.go
.