specialize tweight on FixedPoint conditionally #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If upstream package (e.g., Interpolations, FixedPointNumbers) doesn't provide such specialization, then we add one here. This trick avoids incremental compilation warnings
Evizero
reviewed
Jan 30, 2020
| @@ -12,6 +12,7 @@ IdentityRanges = "bbac6d45-d8f3-5730-bfe4-7a449cd117ca" | |||
| ImageCore = "a09fc81d-aa75-5fe9-8630-4744c3626534" | |||
| ImageFiltering = "6a3955dd-da59-5b1f-98d4-e7296123deb5" | |||
| ImageTransformations = "02fcd773-0e25-5acc-982a-7f6622650795" | |||
| InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240" | |||
|
yes
Johnny Chen
陈久宁
School of Mathematical Sciences, East China Normal University, Shanghai
华东师范大学数学科学学院
2020年1月30日 +0800 18:29 Christof Stocker <[email protected]>，写道：
… @Evizero commented on this pull request.
In Project.toml:
> @@ -12,6 +12,7 @@ IdentityRanges = "bbac6d45-d8f3-5730-bfe4-7a449cd117ca"
ImageCore = "a09fc81d-aa75-5fe9-8630-4744c3626534"
ImageFiltering = "6a3955dd-da59-5b1f-98d4-e7296123deb5"
ImageTransformations = "02fcd773-0e25-5acc-982a-7f6622650795"
+InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
is that a stdlib?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Evizero
approved these changes
Jan 30, 2020
johnnychen94
added
the
no changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If upstream package (e.g., Interpolations, FixedPointNumbers) doesn't
provide such specialization, then we add one here.
This trick avoids incremental compilation warnings
This PR duplicates JuliaImages/ImageTransformations.jl#89 to preserve compatibility
The test is likely to fail due to issue #38, but I've got it passed locally by commenting out those tests on accuracy