-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrap applyeager with plain_array #48
Conversation
it's more "eagerly" than contiguous
43495c0
to
551302e
Compare
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Augmentor.jl/Augmentor.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Augmentor.jl/Augmentor.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Augmentor.jl/Augmentor.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
It's more "eagerly" than
contiguous
, simplifies the codes and we can intuit the results more easily.Previously there're operations followed by
plain_array
,contiguous
and nothing. Sinceplain_array
only strips the Offset wrapper on the top ofcontiguous
, there shouldn't be any performance regression here.P.S. upgrading to OffsetArrays 1.0 is a little challenge with the over-verbose test cases; one breaking change is
axes(img_offset)
now returns tuple ofOffsetArrays.IdOffsetRange
. (Before that it'sBase.IdentityUnitRange
in julia v1.0 orOffsetArrays.IdentityUnitRange
in julia >= v1.1 ). Hence I decided to strip the OffsetArray wrapper for eager mode augmentation.@Evizero This PR might diverge what you expected in #24