Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests, fix HyperLink order, add method ValidateDocument() #87

Merged
merged 5 commits into from
Nov 25, 2022

Conversation

PrzemyslawKlys
Copy link
Member

@PrzemyslawKlys PrzemyslawKlys commented Nov 25, 2022

This PR solves:

  • As part of one PR, we found that the order of elements matters and we didn't notice it during the PR assessment. This PR adds a check right after document saving if there are any unexpected child elements. This should temporary work as an easy way to detect problems. In the long run document.ValidationErrors should be 0, but so far we have some issues to solve first
  • changes order of elements in Hyperlink for Color, adds missing Value
  • Add method ValidateDocument() with ability to define file format. Default is Microsoft365.

@PrzemyslawKlys PrzemyslawKlys changed the title Improve tests by adding Validation check that checks for elements out of order Improve tests, fix HyperLink order, add method ValidateDocument() Nov 25, 2022
@PrzemyslawKlys PrzemyslawKlys merged commit 069e75b into master Nov 25, 2022
@PrzemyslawKlys PrzemyslawKlys deleted the ValidationTests branch November 25, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant