Suppress unit test calling openfast #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasmith4
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
@psakievich I'm fine with this, but can you create a companion issue so we don't lose track that we need to circle back to this?
|
Is it because we randomize the test order? |
|
@jrood-nrel I don't think that is the issue. I'm not sure yet. But I'm also tired of trying to make it work. The test is not adding value equal to what it is costing us. Unfortunately whenever openfast gets run it creates a whole bunch of files. I think there is a conflict in the files/and/or some read operation. It could also be an issue with the controller library dynamically linking with some overlap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.